-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): ensure listbox optionn ids in groups are always unique #893
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/twilio-dsys/paste/gl5u6iu9c |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eab21ab:
|
Size Change: +8 B (0%) Total Size: 371 kB
ℹ️ View Unchanged
|
Due to the way groups of options are rendered, that start at a fresh index meaning you get duplicate ids across groups.
Ensure that this doesn't happen and write a test to make sure it never happens again.