Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off skipLibCheck in tsconfig #451

Open
dkundel opened this issue Jan 11, 2023 · 0 comments
Open

Turn off skipLibCheck in tsconfig #451

dkundel opened this issue Jan 11, 2023 · 0 comments

Comments

@dkundel
Copy link
Member

dkundel commented Jan 11, 2023

The tsconfig.base.json file currently has skipLibCheck set to true (introduced in #450) which avoids throwing errors from TypeScript if one of the TypeScript definition files has an error. While this isn't a huge issue in terms of catching functional issues, it could introduce frustrations for customers who might use our own TypeScript definitions if those reference broken types.

In order to turn this off we need to make sure that after turning it off all relevant external types are updated and fixed if we have control over it.

@dkundel dkundel mentioned this issue Jan 11, 2023
10 tasks
@makserik makserik added this to the Improvements/Nice to haves milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants