Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-handler): don't check for exact Content-Type matches #392

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

philnash
Copy link
Contributor

@philnash philnash commented Apr 4, 2022

Content-Type headers may have the media type followed by a semicolon,
followed by some parameters, for example "charset=UTF-8". This fix
ensures that only the start of the Content-Type header matches
application/json when stringifying the body to JSON.

Fixes #391

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Content-Type headers may have the media type followed by a semicolon,
followed by some parameters, for example "charset=UTF-8". This fix
ensures that only the start of the Content-Type header matches
application/json when stringifying the body to JSON.

Fixes #391
@philnash philnash requested a review from dkundel April 4, 2022 05:23
@makserik makserik added this to the Post v3 milestone Mar 25, 2024
@makserik makserik added the bug Something isn't working label Mar 25, 2024
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: dde4349

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@twilio/runtime-handler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@victoray victoray merged commit 34de081 into main Mar 26, 2024
10 checks passed
@victoray victoray deleted the handle-content-type-with-additional-data branch March 26, 2024 08:27
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Type header check in response is not handling charset
3 participants