Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin node version to 14.18.1 in Dockerfile #310

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

onuzbee
Copy link
Contributor

@onuzbee onuzbee commented Oct 14, 2021

Fixes

Closes DII-162. Tested basic functionality of CLI.

Screenshot 2021-10-14 at 4 03 12 PM

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@@ -1,4 +1,4 @@
FROM node:lts
FROM node:14.18.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why would we need to pin it to patch level granularity, in general?

I understand that after 14.18.1, the version was bumped up to 15 an so on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are following the LTS release(Long term support), and the latest version of it is what @onuzbee has added which is 14.18.1, once the newer version starts supporting LTS, we would then have to update it, but for now the latests is for 14.18.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@onuzbee onuzbee merged commit 0588491 into main Oct 18, 2021
@onuzbee onuzbee deleted the docker-pin-node branch October 18, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants