Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the 'incoming-phone-number' topic to 'phone-numbers' #36

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

childish-sambino
Copy link
Contributor

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  • Switch the 'incoming-phone-number' topic to 'phone-numbers'

If you have questions, please file a support ticket, or create a Github Issue in this repository.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #36 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files          22       22              
  Lines         570      568       -2     
==========================================
- Hits          561      559       -2     
  Misses          9        9
Impacted Files Coverage Δ
src/commands/phone-numbers/update.js 100% <ø> (ø)
src/commands/phone-numbers/list.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ae804...d2ec6a2. Read the comment docs.

Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that code coverage went down. I think it's OK.

@childish-sambino
Copy link
Contributor Author

@thinkingserious It's because 2 tested lines were removed (the aliasing).

@childish-sambino childish-sambino merged commit bdf1775 into master Jun 6, 2019
@childish-sambino childish-sambino deleted the phone-numbers branch June 6, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants