Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ToXDocument method to TwiML #649

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

Swimburger
Copy link
Contributor

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

Fixes #648

This PR adds the ToXDocument method to the TwiML class.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@mattcole19 mattcole19 added type: community enhancement feature request not on Twilio's roadmap status: ready for merge code deemed fit for merge labels Nov 16, 2022
Copy link

@mattcole19 mattcole19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@mattcole19 mattcole19 merged commit dd6e56e into twilio:main Nov 16, 2022
@Swimburger Swimburger deleted the to-xdocument branch November 16, 2022 22:57
Swimburger added a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready for merge code deemed fit for merge type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ToXDocument to TwiML class
2 participants