Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consolidate #204

Merged
merged 12 commits into from
Apr 13, 2023
Merged

docs: consolidate #204

merged 12 commits into from
Apr 13, 2023

Conversation

stern-shawn
Copy link
Contributor

Fixes

As part of the docs changes, I'm consolidating docs content into GitHub so that we can more closely version our content.

@stern-shawn stern-shawn changed the title Docs/consolidate docs: consolidate Apr 4, 2023
README.md Outdated Show resolved Hide resolved
"encoding/json"
"fmt"

"github.com/twilio/twilio-go"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

Suggested change
"github.com/twilio/twilio-go"
twilio "github.com/twilio/twilio-go"

We refer to e.g. "twilio.NewRestClient" below without explaining where the 'twilio' comes from

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be necessary, at least based on the behavior of my IDE. If it's a Go convention, sure, but I'd rather not edit every sample unless it's warranted.
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's not necessary for sure I just want to avoid confusion. Most of the time the package name matches the import but when they don't match it's not always obvious where it's coming from.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always rename these in my own programs for clarity FYI, I'm not just saying this because it's a tutorial, and it doesn't increase the line count.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shrutiburman shrutiburman merged commit 40e2a58 into twilio:main Apr 13, 2023
@fulyagroupstone
Copy link

Düzeltmeler

Doküman değişikliklerinin bir parçası olarak , içeriğimizi daha yakından versiyonlayabilmek için doküman içeriğini GitHub'da birleştiriyorum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants