Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support setting null account sid #688

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: support setting null account sid #688

merged 1 commit into from
May 31, 2022

Conversation

aarya-brex
Copy link
Contributor

@aarya-brex aarya-brex commented May 25, 2022

Fixes

Account SID is a nullable field, we should allow setting the accountSid to null for users managing multiple rest clients

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@childish-sambino childish-sambino merged commit 087f309 into twilio:main May 31, 2022
@aarya-brex
Copy link
Contributor Author

Will you be able to cut us a new version?

@childish-sambino
Copy link
Contributor

Next release is scheduled for tomorrow (generally, every second Wednesday).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants