Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset account sid when using username and password only #692

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: reset account sid when using username and password only #692

merged 1 commit into from
May 31, 2022

Conversation

aarya-brex
Copy link
Contributor

@aarya-brex aarya-brex commented May 31, 2022

Fixes

Following #688, we should sets account sid to null if it's not used for current form of authentication

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@aarya-brex
Copy link
Contributor Author

@childish-sambino, found a potential corner case that may confuse folks

@childish-sambino childish-sambino merged commit e145742 into twilio:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants