Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix repeated get content calls issue #706

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix: fix repeated get content calls issue #706

merged 1 commit into from
Sep 6, 2022

Conversation

kridai
Copy link
Contributor

@kridai kridai commented Sep 5, 2022

Fixes

Fixes DII-573

Adding a fix for the issue found here.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@kridai kridai changed the title fix: fix repeated get content calls fix: fix repeated get content calls issue Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

charan678
charan678 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@charan678 charan678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kridai kridai merged commit 3790f45 into main Sep 6, 2022
@kridai kridai deleted the fix-content-issue branch September 6, 2022 05:00
@childish-sambino childish-sambino mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charan678 charan678 charan678 approved these changes

@shrutiburman shrutiburman Awaiting requested review from shrutiburman

@sr010 sr010 Awaiting requested review from sr010

@rohith-prakash rohith-prakash Awaiting requested review from rohith-prakash

@childish-sambino childish-sambino Awaiting requested review from childish-sambino

@isha689 isha689 Awaiting requested review from isha689

@AsabuHere AsabuHere Awaiting requested review from AsabuHere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kridai @charan678