Remove the jwt-simple dependency. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using two JWT dependencies, jwt-simple and jsonwebtoken. Issue #205 points out a vulnerability in jwt-simple 0.1.0 which lay within the dependencies. Removing it completely in favour of jsonwebtoken was the easiest course of action.
|
Hey @philnash https://snyk.io/vuln/npm:jwt-simple:20160804 I was getting this issue and found that its already in Progress . Please merge this and release new NPM . Thanks a lot! |
|
👍 |
|
When will this get pushed to npm? |
|
This has been pushed to npm for the version 3 prerelease as v3.0.0-rc.14. I'm pushing for the v2 library to be updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using two JWT dependencies, jwt-simple and jsonwebtoken. Issue #205 points out a vulnerability in jwt-simple 0.1.0 which lay within the dependencies. Removing it completely in favour of jsonwebtoken was the easiest course of action.
We could probably do this for master and the current version of twilio-node too. Less dependencies and less vulnerabilities would be awesome.