Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to fix vulnerabilities (#343) #347

Merged
merged 4 commits into from
May 25, 2018
Merged

Update dependencies to fix vulnerabilities (#343) #347

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
618ff69
Update dependencies to fix vulnerabilities #343
dkundel May 18, 2018
59f138f
Merge branch 'master' into fix-sec-issue-343
cjcodes May 18, 2018
590db6b
Merge branch 'master' into fix-sec-issue-343
cjcodes May 25, 2018
f354afa
Temporarily rollback version bumps for jshint & nsp
dkundel May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,23 @@
"url": "https://github.com/twilio/twilio-node.git"
},
"dependencies": {
"deprecate": "1.0.0",
"jsonwebtoken": "^8.1.0",
"lodash": "^4.17.10",
"moment": "2.19.3",
"q": "2.0.x",
"request": "2.85.x",
"request": "^2.86.0",
"rootpath": "0.1.2",
"scmp": "0.0.3",
"xmlbuilder": "9.0.1",
"deprecate": "1.0.0"
"xmlbuilder": "9.0.1"
},
"devDependencies": {
"express": "3.x",
"jasmine-node": "1.14.5",
"express": "^4.16.3",
"jasmine-node": "^1.14.5",
"jscs": "3.0.7",
"jsdoc": "3.5.5",
"jshint": "2.8.x",
"nsp": "2.8.0",
"jshint": "^2.9.5",
"nsp": "^3.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkundel Looks like this version bump is breaking node v5 + v4. We'll probably try to move to npm audit in the future, but do you think rolling this back is fine for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm fine with it now. Can you log a bug to upgrade them later?

But v4 + v5 are both deprecated so we should definitely target moving off them soon. I think security is more important in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, not just deprecated but EOL-ed. So is v7. I'll log a ticket to coordinate dropping them.

"proxyquire": "1.8.0"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion spec/validation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('Testing Express request validation', function() {
var app = require('express')();

// Use url-encoded body parser
app.use(express.urlencoded());
app.use(express.urlencoded({ extended: false }));

// create a simple TwiML-serving web app that will validate a request
// was originated by Twilio
Expand Down