Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Correct video composition date types #486

Merged
merged 1 commit into from
Oct 7, 2019
Merged

breaking: Correct video composition date types #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/rest/video/v1/composition.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@ interface CompositionResource {
audio_sources: string[];
audio_sources_excluded: string[];
bitrate: number;
date_completed: string;
date_completed: Date;
date_created: Date;
date_deleted: string;
date_deleted: Date;
duration: number;
format: CompositionFormat;
links: string;
Expand Down Expand Up @@ -285,9 +285,9 @@ declare class CompositionInstance extends SerializableClass {
audioSources: string[];
audioSourcesExcluded: string[];
bitrate: number;
dateCompleted: string;
dateCompleted: Date;
dateCreated: Date;
dateDeleted: string;
dateDeleted: Date;
duration: number;
/**
* fetch a CompositionInstance
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/video/v1/composition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,8 @@ CompositionPage.prototype[util.inspect.custom] = function inspect(depth,
* @property {composition.status} status - The status of the composition
* @property {Date} dateCreated -
* The ISO 8601 date and time in GMT when the resource was created
* @property {string} dateCompleted - Date when the media processing task finished
* @property {string} dateDeleted -
* @property {Date} dateCompleted - Date when the media processing task finished
* @property {Date} dateDeleted -
* The ISO 8601 date and time in GMT when the composition generated media was deleted
* @property {string} sid - The unique string that identifies the resource
* @property {string} roomSid -
Expand Down Expand Up @@ -555,8 +555,8 @@ CompositionInstance = function CompositionInstance(version, payload, sid) {
this.accountSid = payload.account_sid; // jshint ignore:line
this.status = payload.status; // jshint ignore:line
this.dateCreated = deserialize.iso8601DateTime(payload.date_created); // jshint ignore:line
this.dateCompleted = payload.date_completed; // jshint ignore:line
this.dateDeleted = payload.date_deleted; // jshint ignore:line
this.dateCompleted = deserialize.iso8601DateTime(payload.date_completed); // jshint ignore:line
this.dateDeleted = deserialize.iso8601DateTime(payload.date_deleted); // jshint ignore:line
this.sid = payload.sid; // jshint ignore:line
this.roomSid = payload.room_sid; // jshint ignore:line
this.audioSources = payload.audio_sources; // jshint ignore:line
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/video/v1/compositionHook.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ interface CompositionHookResource {
audio_sources: string[];
audio_sources_excluded: string[];
date_created: Date;
date_updated: string;
date_updated: Date;
enabled: boolean;
format: CompositionHookFormat;
friendly_name: string;
Expand Down Expand Up @@ -316,7 +316,7 @@ declare class CompositionHookInstance extends SerializableClass {
audioSources: string[];
audioSourcesExcluded: string[];
dateCreated: Date;
dateUpdated: string;
dateUpdated: Date;
enabled: boolean;
/**
* fetch a CompositionHookInstance
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/video/v1/compositionHook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ CompositionHookPage.prototype[util.inspect.custom] = function inspect(depth,
* @property {boolean} enabled - Whether the CompositionHook is active
* @property {Date} dateCreated -
* The ISO 8601 date and time in GMT when the resource was created
* @property {string} dateUpdated -
* @property {Date} dateUpdated -
* The ISO 8601 date and time in GMT when the resource was last updated
* @property {string} sid - The unique string that identifies the resource
* @property {string} audioSources -
Expand Down Expand Up @@ -556,7 +556,7 @@ CompositionHookInstance = function CompositionHookInstance(version, payload,
this.friendlyName = payload.friendly_name; // jshint ignore:line
this.enabled = payload.enabled; // jshint ignore:line
this.dateCreated = deserialize.iso8601DateTime(payload.date_created); // jshint ignore:line
this.dateUpdated = payload.date_updated; // jshint ignore:line
this.dateUpdated = deserialize.iso8601DateTime(payload.date_updated); // jshint ignore:line
this.sid = payload.sid; // jshint ignore:line
this.audioSources = payload.audio_sources; // jshint ignore:line
this.audioSourcesExcluded = payload.audio_sources_excluded; // jshint ignore:line
Expand Down