New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for adding child nodes / text #484

Merged

ekarson merged 1 commit into master from DX-299_tests

Jun 21, 2018

Contributor

ekarson commented Jun 20, 2018

Added a test for mixed content, which uncovered a couple of related problems:

There is no way to access generic nodes to add more children -- fixed the return value for addChild.
The addText method is duplicative -- removed it. (This is technically a breaking change -- what do you all think?)


          add test for mixed content; remove unneeded addText method; return ne…

27f236b

…w child node in addChild

ekarson requested review from cjcodes, yannieyip and mbichoffe

June 20, 2018 23:31

yannieyip approved these changes

View reviewed changes

ekarson merged commit f7d4282 into master

ekarson deleted the DX-299_tests branch

June 21, 2018 19:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment