Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide application/json support in request body #799

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Provides application/json type suport for request body

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 marked this pull request as draft March 20, 2024 09:58
@tiwarishubham635 tiwarishubham635 marked this pull request as ready for review March 20, 2024 10:00
UPGRADE.md Outdated
@@ -2,6 +2,11 @@

_MAJOR version bumps will have upgrade notes posted here._

[2023-03-25] 7.x.x to 8.x.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 8.0.0-rc.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct, I'll do this

@@ -0,0 +1,97 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are generating these files ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding them for the first time so that tests do not fail, similar to what we did in case of python.
Moving ahead, it will be autogenerated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose if a new API is added from api-definitions, Do we need to do this at that time ?

@tiwarishubham635 tiwarishubham635 merged commit 3ac1dab into 8.0.0-rc Mar 26, 2024
14 checks passed
@tiwarishubham635 tiwarishubham635 deleted the json_ingress branch March 26, 2024 09:32
tiwarishubham635 added a commit that referenced this pull request Apr 4, 2024
* chore: provide application/json support in request body (#799)

* fix: added support for json content type

* chore: added static files for preview messaging

* chore: corrected name casing

* chore: upgrade guide and changelog updated

* chore: updated rc in VersionInfo.php

* chore: updated rc version

* feat!: MVR preparation (#802)

* docs: added messaging bulk example

* docs: corrected text message

* feat!: MVR preparation

---------

Co-authored-by: Twilio <team_interfaces+github@twilio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants