Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Android 4.3.0: Dominant Speaker #426

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

zackm0571
Copy link
Contributor

4.3.0

API Changes

  • Implemented the Dominant Speaker functionality for Group Rooms. To enable the dominant speaker functionality, set the ConnectOptions.dominantSpeakerEnabled property to true when connecting to a Group Room. To determine the current dominant speaker, query the Room.getDominantSpeaker() method. When there is no dominant speaker, the ConnectOptions.dominantSpeakerEnabled property was set to false or when using a Peer-to-Peer room, the Room.getDominantSpeaker() method will always return null. When there is a dominant speaker, the Room.getDominantSpeaker() method will return the appropriate RemoteParticipant. Implementing Room.Listener.onDominantSpeakerChanged() method on your Room.Listener will allow you to receive callbacks when the dominant speaker in a Group Room changes. The onDominantSpeakerChanged argument will contain the RemoteParticipant of the dominant speaker, or null if there is no longer a dominant speaker.
 ConnectOptions connectOptions =
                new ConnectOptions.Builder(token)
                        .roomName(roomName)
                        .enableDominantSpeaker(true)
                        .build();
Room room = Video.connect(context, connectOptions, roomListener);

@Override
void onDominantSpeakerChanged(
                @NonNull Room room, @Nullable RemoteParticipant remoteParticipant) {
                // Handle dominant speaker change
        }

Known issues

  • Network handoff, and subsequent connection renegotiation is not supported for IPv6 networks #72
  • Participant disconnect event can take up to 120 seconds to occur #80 #73
  • The SDK is not side-by-side compatible with other WebRTC based libraries #340
  • Codec preferences do not function correctly in a hybrid codec Group Room with the following
    codecs:
    • ISAC
    • PCMA
    • G722
    • VP9
  • Unpublishing and republishing a LocalAudioTrack or LocalVideoTrack might not be seen by Participants. As a result, tracks published after a Room.State.RECONNECTED event might not be subscribed to by a RemoteParticipant.

@zackm0571 zackm0571 requested a review from aaalaniz August 5, 2019 18:15
@zackm0571 zackm0571 merged commit 5dac095 into master Aug 5, 2019
@aaalaniz aaalaniz deleted the release/video-android-4.3.0 branch October 20, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants