Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bundle assets in binary #47

Closed
Exagone313 opened this issue Nov 21, 2020 · 2 comments · Fixed by #340
Closed

feat: Bundle assets in binary #47

Exagone313 opened this issue Nov 21, 2020 · 2 comments · Fixed by #340
Labels
feature New feature or request

Comments

@Exagone313
Copy link
Contributor

Actually, assets are loaded using a relative path in the repository:

https://github.com/TwinProduction/gatus/blob/76d45d7eb8bca0dcf01e503234832d45e8aee884/main.go#L34

My proposal is to bundle assets into the gatus binary, to ease distribution with a single binary.

This can probably be done with go-bindata.
@mapl
Copy link

mapl commented Nov 21, 2020

Next year, probably with Go 1.16, embedding static files will be introduced into the standard library.

https://go.googlesource.com/proposal/+/master/design/draft-embed.md

@Exagone313
Copy link
Contributor Author

It's live now: https://golang.org/pkg/embed/

@TwiN TwiN added the feature New feature or request label Sep 4, 2021
@RasmusLindroth RasmusLindroth mentioned this issue Oct 15, 2021
Closed
@TwiN TwiN changed the title Bundle assets in binary feat: Bundle assets in binary Oct 9, 2022
TwiN added a commit that referenced this issue Oct 9, 2022
@TwiN
feat: Bundle assets in binary using go:embed
3a91221 
Fixes #47
This was referenced Oct 9, 2022
Open
Merged
@TwiN TwiN closed this as completed in #340 Oct 10, 2022
TwiN added a commit that referenced this issue Oct 10, 2022
@TwiN
feat: Bundle assets in binary using go:embed (#340)
00b56ec 
Fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@mapl @Exagone313 @TwiN