Ants 2203 migrate bamboo to airbyte #4
Conversation
…-bamboo-to-airbyte
…eteam/airbyte into ANTS-2203-Migrate-bamboo-to-airbyte
…here's columns for everything. Non-string data gets put into _airbyte_additional_properties within the column.
| def get_default_bamboo_fields() -> List[str]: | ||
| # As per https://documentation.bamboohr.com/docs/list-of-field-names | ||
| return [ | ||
| "acaStatus" |
There was a problem hiding this comment.
Let's remove this as it's deprecated
There was a problem hiding this comment.
My only concern is we may encounter some client with a legacy setup that is still making use of it (and not the new version, acaStatusCategory). Seems like we might want to err on the side of caution and just try to pull it in. We can choose to use it (or not) at the transform layer. What do you think?
There was a problem hiding this comment.
should be fine, I think we just need to check that the deprecated fields don't result in weird bamboo endpoint error. I rmb previously when we included a deprecated field flsaCode it basically shifted all the values and keys and caused the values to be on the wrong keys in the response.
There was a problem hiding this comment.
Got it, I'll remove then. We can always add it back if someone complains (unlikely).
Updates Bamboo source for our use case.