-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always return normalized urls in lower case #8
Comments
From http://stackoverflow.com/questions/7996919/should-url-be-case-sensitive
Another answer cites W3:
|
Yeah, true. How about just the protocol part? I'll change the issue title in that case. |
|
Sounds good to me |
http://stackoverflow.com/questions/2148603/is-the-protocol-name-in-urls-case-sensitive
|
Actually, I've changed my mind. Lower case everything, but don't use it for other than comparison. Always save the original URL (with lower case protocol), and use that when requesting or linking to the resource. |
@jage Uhm, this is a library, it doesn't save anything? |
Yes, I'm thinking of when you're using this library. We need to separate normalized URLs and original URLs. |
So, lower case scheme and hostname. Write a test and code that makes the test pass, then we can close this issue. |
Isn't that a discussion we should have in another issue? Or do you propose additional functions to this library? |
No need for a special issue. Since we're discussing it here I thought it would be suitable to give my thoughts about how to actually use the normalized URLs.
No. You can't reason about how this library should act unless you talk about how it should be used. |
Closing this in favor of #9, because I think that is more clear than changing the title of this issue. I like our issues short and precise. If we want the hostname in lower case, I think we should open a new issue about that. I'm not sure we should add that functionality just because. It's a good idea, that @jage mentioned, to be able to do comparisons, but I think we can open a new issue on this repo to discuss that. |
I agree with this. I think it's the correct behavior for this gem. I think I had a hard time agreeing before, because we are doing it wrong in zambezi, we don't save original the URL, we save the normalized URL. |
URLs are not case-insensitive, but since our normalized URLs are just used internally, it's ok. The original URL should always be used when actually requesting a resource. Close #8
This would avoid problems with Autoping as it currently requires at least the protocol to be in lower-case.
I can't think of any drawback of doing this, can anyone else?
The text was updated successfully, but these errors were encountered: