Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy with .NET normalization #12

Closed
walro opened this issue Apr 21, 2014 · 4 comments
Closed

Discrepancy with .NET normalization #12

walro opened this issue Apr 21, 2014 · 4 comments

Comments

@walro
Copy link
Contributor

walro commented Apr 21, 2014

Using url: http://www.blog.com/feed/ the normalizer returns http://www.blog.com/feed/ while the .NET based normalization would return http://www.blog.com/feed. So this library is not safe to use in conjunction with .NET based projects, such as Autoping.

The .NET filtering is done in: \trunk\Utilities\Filtering\UrlFilter.cs

In: \trunk\Utilities\Filter.Test\TestUrlFilter.cs there are lots of tests defining the behavior (Including tests for stripping trailing slash in path).

@dentarg
Copy link
Collaborator

dentarg commented Sep 5, 2014

Another discrepancy is IDNs (#17).

@jage
Copy link
Contributor

jage commented Oct 30, 2014

Another is to remove www. for subdomains #18

@roback roback added the critical label Jul 7, 2015
@roback
Copy link
Member

roback commented Jul 7, 2015

This is needed to test whether a url is added to autoping, as im trying to do in https://trello.com/c/KG5vNOEA/1286-sommar2015-verktyg-for-att-jobba-med-url-listor

@jage
Copy link
Contributor

jage commented Aug 24, 2015

We discussed this on the sprint meeting for sprint 32 and decided that this isn't critical. We would very much like this, but it won't be prioritized now.

@jage jage removed the critical label Aug 24, 2015
roback pushed a commit that referenced this issue Sep 8, 2015
roback pushed a commit that referenced this issue Sep 9, 2015
This is the same behavior as the .NET normalization.

Part of #12.

Related to #8, #9 (and #23).
roback pushed a commit that referenced this issue Sep 9, 2015
@roback roback closed this as completed in #37 Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants