Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PublicSuffix 2.0 #85

Closed
dentarg opened this issue Aug 17, 2016 · 2 comments · Fixed by #90
Closed

Use PublicSuffix 2.0 #85

dentarg opened this issue Aug 17, 2016 · 2 comments · Fixed by #90
Labels
enhancement

Comments

@dentarg
Copy link
Collaborator

dentarg commented Aug 17, 2016

This summer, PublicSuffix 2.0 was released. It sure looks interesting.

https://github.com/weppos/publicsuffix-ruby/blob/master/2.0-Upgrade.md (current permalink)

PublicSuffix 2.0 contains a rewritten internal representation and comparison logic, that drastically increases the lookup performance. The new version also changes several internal and external API.
@dentarg
Copy link
Collaborator Author

dentarg commented Aug 17, 2016

FYI we currently have s.add_dependency "public_suffix", "~> 1.4" in our gemspec

@dentarg
Copy link
Collaborator Author

dentarg commented Aug 17, 2016

Looked this up because I noticed warnings from public_suffix when running the zambezi tests. That was taken care of in 2.0: weppos/publicsuffix-ruby@6e26b65

dentarg added a commit that referenced this issue Sep 9, 2016
@dentarg
Use PublicSuffix 2
cd38e55 
Related to #89 and #71.

Close #85.
@dentarg dentarg mentioned this issue Sep 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure normalized IDNA domains return ASCII strings twingly/twingly-url
1 participant
@dentarg