Accept that parsing downcases the scheme part, allow Addressable 2.6 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the situation since Addressable 2.6: sporkmonger/addressable#281 Close #132
|
Does this require another major bump? 😬 Something changed, but I don't think it is particular breaking. |
dentarg
changed the title
walro
reviewed
Feb 6, 2019
I don't know honestly. But seeing we're probably the only ones on version 6 I think we can go with 6.1 or even 6.0.1 here if we decide the previous behavior was a bug :) |
walro
approved these changes
Feb 7, 2019
|
We have always downcased the scheme when normalizing, and I would argue that is in that situation it matters, when you want to compare URLs. Not sure what more one can do with URLs, other than "use" them, e.g. connect to them, and that should still work. That's my reasoning at least. :) |
|
Sounds reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the situation since Addressable 2.6: sporkmonger/addressable#281
Close #132