Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addressable to 2.6 #132

Closed
jage opened this issue Feb 6, 2019 · 3 comments
Closed

Update addressable to 2.6 #132

jage opened this issue Feb 6, 2019 · 3 comments

Comments

@jage
Copy link
Contributor

jage commented Feb 6, 2019

We're limiting to 2.5 currently:

s.add_dependency "addressable", "~> 2.5.2"

Did a quick test, but we need to either change our specs or look into why the protocol is updated:

Failures:

  1) Twingly::URL.parse when given valid urls does not ruin the url "hTTP://blog.twingly.com/"
     Failure/Error: expect(described_class.parse(valid_url).to_s).to eq(valid_url)

       expected: "hTTP://blog.twingly.com/"
            got: "http://blog.twingly.com/"

       (compared using ==)
     # ./spec/lib/twingly/url_spec.rb:124:in `block (5 levels) in <top (required)>'
@dentarg
Copy link
Collaborator

dentarg commented Feb 6, 2019

It is this change upstream: https://github.com/sporkmonger/addressable/pull/281/files

@dentarg
Copy link
Collaborator

dentarg commented Feb 6, 2019

I think we should just accept that case of scheme isn't preserved (we could write a spec for it).

@jage
Copy link
Contributor Author

jage commented Feb 6, 2019

Yeah I think that's reasonable.

dentarg added a commit that referenced this issue Feb 6, 2019
This is the situation since Addressable 2.6: sporkmonger/addressable#281

Close #132
@dentarg dentarg added the bug label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants