Make things private #69
Conversation
|
|
|
|
I am guessing due to the extra three calls in LGTM! |
Ah, no, I think we make an extra parsing now, I think we should fix that. |
| @@ -101,7 +99,7 @@ def normalized | |||
| normalized_url.host = normalized_host | |||
| normalized_url.path = normalized_path | |||
|
|
|||
| self.class.internal_parse(normalized_url) | |||
| self.class.parse(normalized_url) | |||
There was a problem hiding this comment.
This will convert an addressable uri to a string (in .parse) and then back to a addressable uri (in .internal_parse). I think we want to avoid that.
There was a problem hiding this comment.
I think it's pretty easily amended by splitting internal_parse into two different ones, one for addressable and one for public suffix
There was a problem hiding this comment.
I think it's pretty easily amended by splitting internal_parse into two different ones, one for addressable and one for public suffix
We already had a helper method apparently, I thought the change in 219cf37 made sense
For performance, you know
|
Would be interesting to re-run the benchmarks now |
Total: 1.793219 |
|
Cool |
|
@walro are we done? :) |
|
I think so! |
We don't think we will use any inheritance.
#newand.internal_parseClose #60.