Make more methods private

[dentarg]

I tought of this when I saw .to_addressable_uri. I think we want to decrease the number of methods we expose, so we know what we can change without breaking stuff for users.

We can do it like

private_class_method \
def self.foo
end

And if we feel the need to test, there is https://github.com/barelyknown/rspec-context-private

[walro]

I tought of this when I saw .to_addressable_uri. I think we want to decrease the number of methods we expose, so we know what we can change without breaking stuff for users.

Hmm yeah, but sometimes you want to test your helper methods, making them private makes that trickier. (Noticed your link, but another dependency and/or abusing :send doesn't feel that clean. There are other nasty things you can do too)

[twingly-mob]

#58 will make .to_addressable_uri private, but there are more.

We would like to make the following methods private

• Twingly::URL.internal_parse
• Twingly::URL.new
• Twingly::URL#initialize

[dentarg]

We should also make our constants private

[dentarg]

What we have been looking for: http://stackoverflow.com/questions/4950454/class-static-instance-initializers-i-e-factory-methods-in-ruby/4951715#4951715 (credit to @walro for the find)

[dentarg]

Pretty sure there are nothing left to do here and that this should have been closed.