-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more methods private #60
Comments
Hmm yeah, but sometimes you want to test your helper methods, making them private makes that trickier. (Noticed your link, but another dependency and/or abusing |
#58 will make .to_addressable_uri private, but there are more. We would like to make the following methods private
|
We should also make our constants private |
What we have been looking for: http://stackoverflow.com/questions/4950454/class-static-instance-initializers-i-e-factory-methods-in-ruby/4951715#4951715 (credit to @walro for the find) |
Pretty sure there are nothing left to do here and that this should have been closed. |
I tought of this when I saw .to_addressable_uri. I think we want to decrease the number of methods we expose, so we know what we can change without breaking stuff for users.
We can do it like
And if we feel the need to test, there is https://github.com/barelyknown/rspec-context-private
The text was updated successfully, but these errors were encountered: