Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use twisted.python.compat.unicode #397

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Sep 12, 2020

This isn't needed any more since klein dropped support for Python 2.

@rodrigc rodrigc requested a review from a team as a code owner September 12, 2020 05:44
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #397 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   98.36%   98.36%   -0.01%     
==========================================
  Files          46       46              
  Lines        3908     3907       -1     
  Branches      256      256              
==========================================
- Hits         3844     3843       -1     
  Misses         46       46              
  Partials       18       18              
Impacted Files Coverage Δ
src/klein/test/_strategies.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd0890...f5b1c90. Read the comment docs.

@wsanchez
Copy link
Member

I haven't worried about this because #393 but ok

@wsanchez wsanchez merged commit 4267203 into master Sep 12, 2020
@wsanchez wsanchez deleted the no-compat-unicode branch September 12, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants