-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emphasize client #109
Emphasize client #109
Conversation
Glyph pointed out that the various treq request functions (`treq.get()`, `treq.post()`, etc.) don't need to be modified. Instead, the documentation should suggest that you use a `treq.client.HTTPClient` instance directly if you need to customize its behavior. This reverts commit 972b84f.
…client.HTTPClient` is meant to be used.
Current coverage is
|
@cwaldbieser thanks for this update! I just merged another PR that conflicts with this, unfortunately; do you want to remove the |
I’m confused why it removes the custom agent test? I’m also not a fan of replacing treq by a http_client in all examples TBH. It should be documented but this is excessive. |
The custom_agent test was reverted along as part of the change that added I could put all the examples back except the one specific to docs on how Thanks, On Thu, Jul 30, 2015 at 2:51 AM, Hynek Schlawack notifications@github.com
|
I merged the recent change to master back into this branch. |
Oh no, more conflicts :-(. This is actually looking pretty good though, can you resolve the conflicts again and perhaps we can land it? |
I corrected the conflict and pulled out the code that would allow you to pass a custom agent to the short cut functions in |
@cwaldbieser - I was ready to merge this after resolving conflicts... but then I saw you broke compatibility by removing the |
I feel bad about asking you to do something about this only every 6 months and then not merging it, so I've taken over the work in #129 . |
Closing so as not to have a duplicate, but your work is appreciated :). |
Document the release process
Based on a conversation with Glyph in PR #76, I reverted the changes from that PR and instead updated the examples and documentation to emphasize that client code may interact with
treq.client.HTTPClient
directly. In fact this should be the way to customize the behavior of the client. The varioustreq
request functions are just shortcuts.