Disable pycodestyle for now

[twisted-trac]

	@mthuurne reported
Trac ID	trac#9924
Type	task
Created	2020-07-24 04:23:31Z

The incremental code style checking is blocking automated substitutions on the source tree (like #9918 and #9919, but touching more files), since any change close to a piece of pre-existing code that is not style compliant will make pycodestyle complain. This happens so many times that correcting these manually is too much work.

After adopting Black (see #9512), there will either be no need for style checking or it can be done with a much smaller ruleset.

Searchable metadata

trac-id__9924 9924
type__task task
reporter__mthuurne mthuurne
priority__normal normal
milestone__None None
branch__ 
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__None None
time__1595564611511761 1595564611511761
changetime__1603361028506872 1603361028506872
version__None None
owner__mthuurne mthuurne

[twisted-trac]

	@mthuurne commented

PR is here: #1365

[twisted-trac]

	@twm set owner to @twm @twm set status to assigned

[twisted-trac]

	@twm commented

Approved here: #1365 (review)

[twisted-trac]

	@twm set owner to @mthuurne @twm set status to new

[twisted-trac]

	@mthuurne set status to closed

In changeset 9b30362

#!CommitTicketReference repository="" revision="9b30362635561caa64fcbe59892351f8a6cb7d58"
Merge pull request #1365 from twisted/disable_pycodestyle

Disable pycodestyle for now

Author: mthuurne
Reviewer: twm
Fixes: ticket:9924

[twisted-trac]

	@graingert commented

After adopting Black (see #9512), there will either be no need for style checking or it can be done with a much smaller ruleset.

this is simply false - pycodestyle still checks things that black does not

now we black is run pycodestyle will pretty much never complain about good automated changes, for example running pycodestyle would not block these "automated substitutions on the source tree (like #9918 and #9919)"

because black would fix the line lengths