Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11567 Add templates for new issues. #11588

Merged
merged 7 commits into from Aug 9, 2022
Merged

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Jul 22, 2022

Scope

Fixes #11567

This is the initial suggestion for some templates.

They are simple text templates.

Changes

The following templates were created with the following tags auto applied:

  • bug - bug
  • task - NO-LABEL
  • release blocker - bug and release-blocker
  • documentation (for any typos, comments, docs improvements) - documentation

Web forms are not yet used - release-blocker

How to test

There is no way for end to end testing until this is merged,

So maybe make sure this looks ok in general, merge it and then after a hands-on testing, we can update what is left in a separate PR.

With these changes, when a new report is made, users must select one of the available options.
The option of a blank issue is disabled.

@adiroiban adiroiban changed the title Initial templates based on GItHub UI #11567 Add templates for new issues. Jul 22, 2022
@adiroiban
Copy link
Member Author

I think that this is ready for an initial review

needs-review

@adiroiban adiroiban requested a review from a team July 22, 2022 23:35
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start, some suggestions inline.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
Comment on lines 28 to 31
**Testing environment**
- OS: [e.g. linux, windows, macos]
- Twisted version [e.g. 22.2.0]
- Reactor [e.g. select, iocp]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the feedback on the regular-bug template.

@adiroiban
Copy link
Member Author

Thanks for the review. I have applied the suggestions and triggered the auto-merge.

I think that is important to have the templates first, so that we can interact with them.
Later we can look into update the text or the auto-lables and auto assigning

@adiroiban adiroiban merged commit a51bfdd into trunk Aug 9, 2022
@adiroiban adiroiban deleted the 11567-issues-templates branch August 9, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add template for creating new GitHub issues
3 participants