Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "#11655 Update package metadata" #11727

Merged
merged 1 commit into from Oct 25, 2022
Merged

Conversation

glyph
Copy link
Member

@glyph glyph commented Oct 25, 2022

Reverts #11656 due to @alex's bug report

@glyph glyph marked this pull request as ready for review October 25, 2022 23:34
@chevah-robot chevah-robot requested a review from a team October 25, 2022 23:34
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revert.

The approval should be just formal...

We might force the merge... we will see :)

@adiroiban
Copy link
Member

I see that towncrier needs some help to detect when we have a revert PR, and accept the PR even if there is no new fragment.

This PR removes an existing fragment.

@adiroiban
Copy link
Member

If all tests are green, I will temporarily disable the branch protection and merge this.

And I hope that the next time, we will have better support for reverting a PR.

@adiroiban
Copy link
Member

@glyph I have disabled the status checks

this can be merged if you want.

@glyph glyph merged commit bc31b87 into trunk Oct 25, 2022
@glyph glyph deleted the revert-11656-modernize-metadata branch October 25, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants