-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11771 make cfreactor less flaky #12160
Conversation
…vertently cleared
Both of the failures are in so I think this fix actually resolves the issue |
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Many, many thanks for working on this.
Were you able to reproduce the errors on your local system?
I was trying to reproduce them on a macmini m1, without luck.
I think that we should just merge it and see if works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous comment was an "approve".
I was not. But in every other case I managed to reproduce the error in CI after a minimum of 5 tries. The race condition here is extremely subtle, and I couldn't even think of a white-box test to reproduce it, but basically if something were to call |
Scope and purpose
Fixes #11771
This is the change that appeared to have made a difference isolated and extracted from #12150 .