Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lint tooling target versions to py3.6+ #1531

Merged
merged 6 commits into from
Mar 1, 2021

Conversation

graingert
Copy link
Member

@graingert graingert commented Mar 1, 2021

Scope and purpose

update lint tooling target versions to py3.6+

Contributor Checklist:

@graingert graingert force-pushed the configure-tooling-for-py36-plus branch from 309b1e5 to 592568e Compare March 1, 2021 19:55
@graingert graingert force-pushed the configure-tooling-for-py36-plus branch from 592568e to 751b0a5 Compare March 1, 2021 20:08
@graingert
Copy link
Member Author

graingert commented Mar 1, 2021

@wsanchez previously this PR used com2ann to upgrade type annotations, but mypy treats:

class FilePath(AbstractFilePath):
    path = None  # type: Union[bytes, str]

differently to

class FilePath(AbstractFilePath):
    path: Union[bytes, str] = None

the annotation should be:

class FilePath(AbstractFilePath):
    path: Union[bytes, str]

but there's no FilePath.path which is public

@graingert graingert requested a review from wsanchez March 1, 2021 20:42
@graingert graingert merged commit cc50c36 into twisted:trunk Mar 1, 2021
@graingert graingert deleted the configure-tooling-for-py36-plus branch March 1, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants