Documentation links fix - callInThread and callFromThread were 404'd #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #703 +/- ##
==========================================
- Coverage 91.27% 90.19% -1.09%
==========================================
Files 844 844
Lines 147472 147472
Branches 13047 13047
==========================================
- Hits 134612 133013 -1599
- Misses 10623 12186 +1563
- Partials 2237 2273 +36Continue to review full report at Codecov.
|
IReactorThreads.callInThread -> IReactorInThreads.callInThread IReactorThreads.callFromThread -> IReactorFromThreads.callFromThread
jisaacstone
force-pushed
the
9027-jisaacstone-broken_ireactorthreads_links
branch
from
a8f45ea
to
e5215f9
Compare
|
ping |
|
Pong :). If you want to accelerate your review, one way you can do that is by providing your own review on one of the reviews in the queue. The formatting on that page should show you which tickets are open to review by non-committers. Thanks for your contribution! |
glyph
approved these changes
Feb 17, 2017
jisaacstone
deleted the
9027-jisaacstone-broken_ireactorthreads_links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/9027
IReactorThreads.callInThread -> IReactorInThreads.callInThread
IReactorThreads.callFromThread -> IReactorFromThreads.callFromThread
Live Broken Links Found Here:
http://twistedmatrix.com/documents/current/core/howto/logger.html
http://twistedmatrix.com/documents/current/core/howto/threading.html