New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9127] http auth session wrapper py3 fix #773

Merged
merged 4 commits into from Jun 3, 2017

Conversation

Projects
None yet
2 participants
@tardyp
Contributor

tardyp commented Apr 30, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Apr 30, 2017

Codecov Report

Merging #773 into trunk will decrease coverage by 2.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            trunk     #773      +/-   ##
==========================================
- Coverage   91.58%   89.25%   -2.34%     
==========================================
  Files         841      841              
  Lines      146777   146788      +11     
  Branches    12860    12860              
==========================================
- Hits       134432   131017    -3415     
- Misses      10100    13353    +3253     
- Partials     2245     2418     +173

codecov bot commented Apr 30, 2017

Codecov Report

Merging #773 into trunk will decrease coverage by 2.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            trunk     #773      +/-   ##
==========================================
- Coverage   91.58%   89.25%   -2.34%     
==========================================
  Files         841      841              
  Lines      146777   146788      +11     
  Branches    12860    12860              
==========================================
- Hits       134432   131017    -3415     
- Misses      10100    13353    +3253     
- Partials     2245     2418     +173
@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Apr 30, 2017

Contributor

@rodrigc fyi a py3 fix. I am not sure why the buildbot tests are not running.

Contributor

tardyp commented Apr 30, 2017

@rodrigc fyi a py3 fix. I am not sure why the buildbot tests are not running.

@rodrigc

Sometimes these nativeString and networkString functions are a necessary evil, but can we fix this somehow without using them?

Something like:

    l.append(k + b"=" + quoteString(v))

tardyp added some commits Apr 30, 2017

@rodrigc

rodrigc approved these changes Jun 3, 2017

@rodrigc rodrigc merged commit eca6b44 into twisted:trunk Jun 3, 2017

39 checks passed

buildbot/debian8-py2.7 Buildbot test done.
Details
buildbot/documentation Buildbot test done.
Details
buildbot/fedora24-py2.7 Buildbot test done.
Details
buildbot/fedora24-py2.7-coverage Buildbot test done.
Details
buildbot/fedora24-py3.5 Buildbot test done.
Details
buildbot/fedora24-py3.5-coverage Buildbot test done.
Details
buildbot/fedora25-py2.7 Buildbot test done.
Details
buildbot/fedora25-py2.7-coverage Buildbot test done.
Details
buildbot/fedora25-py3.5 Buildbot test done.
Details
buildbot/fedora25-py3.5-coverage Buildbot test done.
Details
buildbot/freebsd10-py2.7 Buildbot test done.
Details
buildbot/freebsd10-py2.7-coverage Buildbot test done.
Details
buildbot/freebsd10-py3.5 Buildbot test done.
Details
buildbot/freebsd10-py3.5-coverage Buildbot test done.
Details
buildbot/osx10.10-py2.7 Buildbot test done.
Details
buildbot/osx10.10-py2.7-coverage Buildbot test done.
Details
buildbot/rhel7-py2.7 Buildbot test done.
Details
buildbot/rhel7-py2.7-coverage Buildbot test done.
Details
buildbot/ubuntu12.04-py2.7 Buildbot test done.
Details
buildbot/ubuntu12.04-py2.7-coverage Buildbot test done.
Details
buildbot/ubuntu14.04-py2.7 Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7 Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-newstyle-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-nodeps Buildbot test done.
Details
buildbot/ubuntu16.04-py2.7-nodeps-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5 Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5-asyncio-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py3.5-coverage Buildbot test done.
Details
buildbot/ubuntu16.04-py3.6 Buildbot test done.
Details
buildbot/ubuntu16.04-py3.6-coverage Buildbot test done.
Details
buildbot/windows7-64-py2.7 Buildbot test done.
Details
buildbot/windows7-64-py2.7-coverage Buildbot test done.
Details
buildbot/windows7-64-py2.7-wheel Buildbot test done.
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project Absolute coverage decreased by -2.33% but relative coverage increased by +8.41% compared to 69b30c9
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment