Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9127] http auth session wrapper py3 fix #773

Merged

Conversation

tardyp
Copy link
Contributor

@tardyp tardyp commented Apr 30, 2017

@codecov
Copy link

Codecov bot commented Apr 30, 2017

Codecov Report

Merging #773 into trunk will decrease coverage by 2.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            trunk     #773      +/-   ##
==========================================
- Coverage   91.58%   89.25%   -2.34%     
==========================================
  Files         841      841              
  Lines      146777   146788      +11     
  Branches    12860    12860              
==========================================
- Hits       134432   131017    -3415     
- Misses      10100    13353    +3253     
- Partials     2245     2418     +173

@tardyp
Copy link
Contributor Author

tardyp commented Apr 30, 2017

@rodrigc fyi a py3 fix. I am not sure why the buildbot tests are not running.

Copy link
Contributor

@rodrigc rodrigc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes these nativeString and networkString functions are a necessary evil, but can we fix this somehow without using them?

Something like:

    l.append(k + b"=" + quoteString(v))

@tardyp tardyp force-pushed the 9127-tardyp-HTTPAuthSessionWrapper-py3-fix branch from 2d87fe3 to dd5eda8 Compare June 2, 2017 18:36
@tardyp tardyp force-pushed the 9127-tardyp-HTTPAuthSessionWrapper-py3-fix branch from dd5eda8 to d8f48f1 Compare June 2, 2017 19:07
@tardyp tardyp force-pushed the 9127-tardyp-HTTPAuthSessionWrapper-py3-fix branch from d8f48f1 to ca14d5a Compare June 2, 2017 19:13
@rodrigc rodrigc merged commit eca6b44 into twisted:trunk Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants