Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration email #97

Merged
merged 4 commits into from
Dec 3, 2016
Merged

Registration email #97

merged 4 commits into from
Dec 3, 2016

Conversation

jerith
Copy link
Contributor

@jerith jerith commented Nov 23, 2016

This addresses #72 and #96.

@mithrandi
Copy link
Contributor

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Nov 23, 2016

Current coverage is 100% (diff: 100%)

Merging #97 into master will not change coverage

@@           master    #97   diff @@
====================================
  Files          27     27          
  Lines        1967   1987    +20   
  Methods         0      0          
  Messages        0      0          
  Branches      174    174          
====================================
+ Hits         1967   1987    +20   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 6cf879b...5a41e34

@mithrandi
Copy link
Contributor

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mithrandi
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


a discussion (no related file):
Oh, one last thing, could you add a news fragment for this?


Comments from Reviewable

@mithrandi
Copy link
Contributor

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@mithrandi mithrandi merged commit a5072fc into twisted:master Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants