Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing a registration email #72

Open
mithrandi opened this issue Sep 5, 2016 · 4 comments
Open

Allow providing a registration email #72

mithrandi opened this issue Sep 5, 2016 · 4 comments

Comments

@mithrandi
Copy link
Contributor

Currently all ACME registrations are anonymous. Let's Encrypt doesn't have a problem with this, but some other future ACME CA might not allow this, and providing an email address with your registration enables you to receive certificate expiration warning emails from Let's Encrypt, which are useful if something goes wrong and you're not watching your logs closely to see the issuing failures from txacme.

@mithrandi mithrandi added this to the 1.0.0 release milestone Sep 5, 2016
@mithrandi mithrandi modified the milestones: 0.9.2 release, 1.0.0 release Dec 3, 2016
@mithrandi
Copy link
Contributor Author

#97 provided the low-level support for this, but the endpoint parameters still need to be extended to support passing an email address.

@glyph
Copy link
Member

glyph commented Jul 8, 2017

I'd love to transitively put support for this into https://github.com/glyph/lancer.

@mithrandi
Copy link
Contributor Author

@glyph Pass the email parameter to AcmeIssuingService here: https://github.com/glyph/lancer/blob/8d065def9bfd19b8b10b9e9c1f7236cd6019f0cb/lancer/_impl.py#L76

@glyph
Copy link
Member

glyph commented Jul 8, 2017

Rad. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants