Merge pull request #244 from tonal/patch-1

Fix dictionary changed size
twisted · Nov 28, 2018 · db7f5f3 · db7f5f3
2 parents b3357d6 + ddbdee0
commit db7f5f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/docs/source/NEWS.rst b/docs/source/NEWS.rst
@@ -9,6 +9,11 @@ Features
 
 - Allow passing only kwargs to `Database.create_collection()`
 
+Bugfixes
+^^^^^^^^
+
+- Fixed RuntimeError: dictionary changed size during iteration in ConnectionPool.dicconnect #243
+
 
 Release 18.2.0 (2018-07-19)
 ---------------------------

diff --git a/txmongo/connection.py b/txmongo/connection.py
@@ -339,7 +339,7 @@ def drop_database(self, name_or_database):
 
     def disconnect(self):
         self.__pinger_discovery.stop()
-        for pinger in self.__pingers.values():
+        for pinger in list(self.__pingers.values()):
             pinger.connector.disconnect()
 
         for factory in self.__pool: