Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymongo 3.5.0 doesn't provide _WriteOp in pymongo.operations #210

Closed
bhyde opened this issue Aug 10, 2017 · 8 comments
Closed

Pymongo 3.5.0 doesn't provide _WriteOp in pymongo.operations #210

bhyde opened this issue Aug 10, 2017 · 8 comments
Labels

Comments

@bhyde
Copy link

bhyde commented Aug 10, 2017

This line:

from pymongo.operations import _WriteOp

is failing since recent release of pymongo 3.5.0.

Pinning to 3.4.0 is a work around.

@bhyde
Copy link
Author

bhyde commented Aug 10, 2017

@psi29a
Copy link
Contributor

psi29a commented Aug 10, 2017

@bhyde Thank you for reporting this!

Looks like we only import _WriteOp to validate that the bulk_insert request is of instance _WriteOp. If I understand correctly, pymongo instead just does a try/except around request._add_to_bulk(blk) in which case we can do the same.

@IlyaSkriblovsky Do you agree?

@psi29a psi29a added the bug label Aug 10, 2017
IlyaSkriblovsky added a commit to IlyaSkriblovsky/txmongo that referenced this issue Aug 10, 2017
IlyaSkriblovsky added a commit to IlyaSkriblovsky/txmongo that referenced this issue Aug 10, 2017
@IlyaSkriblovsky
Copy link
Contributor

Sure, fixed in #211
Thanks, Ben!

@psi29a
Copy link
Contributor

psi29a commented Aug 10, 2017

@IlyaSkriblovsky I was looking for consensus that my assumption was correct, not that you do the work! ;)

@IlyaSkriblovsky
Copy link
Contributor

Sorry, it's sometimes hard to resist when fingers reach the keyboard :)

@psi29a
Copy link
Contributor

psi29a commented Aug 10, 2017

Hah! No worries!

psi29a added a commit that referenced this issue Aug 10, 2017
Fixed compatibility with pymongo 3.5.0 (#210)
@bhyde
Copy link
Author

bhyde commented Aug 11, 2017

Oh, nice turn around. Awesome. I'll keep an eye out for a release. Thanks!

@psi29a
Copy link
Contributor

psi29a commented Aug 11, 2017

Merged... going to close this. If there is a still an issue, please re-open.

Cheers!

@psi29a psi29a closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants