Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing MONGODB-CR auth method #118

Merged
merged 3 commits into from
Jun 5, 2015
Merged

Testing MONGODB-CR auth method #118

merged 3 commits into from
Jun 5, 2015

Conversation

IlyaSkriblovsky
Copy link
Contributor

test_auth.py expoits a hack to force MongoDB to use obsolete MONGODB-CR auth mechanism in order to get coverage of both SCRAM-SHA-1 and MONGODB-CR auth methods.

Travis environment changed to use MongoDB 3.0

@coveralls
Copy link

Coverage Status

Coverage increased (+2.43%) to 94.67% when pulling d1d65c1 on IlyaSkriblovsky:mongodbcr-testing into a540219 on twisted:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+2.43%) to 94.67% when pulling d1d65c1 on IlyaSkriblovsky:mongodbcr-testing into a540219 on twisted:master.

psi29a
psi29a reviewed Jun 5, 2015
View reviewed changes
.travis.yml
@@ -45,7 +45,7 @@ matrix:

before_install:
- "sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 7F0CEB10"
- "echo 'deb http://downloads-distro.mongodb.org/repo/ubuntu-upstart dist 10gen' | sudo tee /etc/apt/sources.list.d/mongodb.list"
- "echo 'deb http://repo.mongodb.org/apt/ubuntu '$(lsb_release -sc)'/mongodb-org/3.0 multiverse' | sudo tee /etc/apt/sources.list.d/mongodb-org-3.0.list"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely found!

@psi29a
Copy link
Contributor

psi29a commented Jun 5, 2015

95% that's really great!

@psi29a
Copy link
Contributor

psi29a commented Jun 5, 2015

I'm only worried about that we're no longer testing mongodb >= 3.0, so the noDups test will always be skipped.

@IlyaSkriblovsky
Copy link
Contributor Author

we're no longer testing mongodb >= 3.0

< 3.0 you meant?
Is it possible to specify different configurations for Travis? I think it won't be easy to install both versions of MongoDB side-by-side...

@psi29a
Copy link
Contributor

psi29a commented Jun 5, 2015

Yeah, sorry. That is what I meant. I thought it could be possible to install both. If not, I could create a PPA package, statically compiled, so that it doesn't interfere with the other installed MongoDB.

Would that work, or overkill?

@IlyaSkriblovsky
Copy link
Contributor Author

Actually, I think it is overkill because it's all about testing two pretty obvious lines of code :)

@psi29a
Copy link
Contributor

psi29a commented Jun 5, 2015

;)

Well, as an option, there is always this:
curl -O http://downloads.mongodb.org/linux/mongodb-linux-x86_64-2.6.10.tgz
^-- statically compiled

psi29a added a commit that referenced this pull request Jun 5, 2015
@psi29a
Merge pull request #118 from IlyaSkriblovsky/mongodbcr-testing
b5aa49c 
Testing MONGODB-CR auth method
@psi29a psi29a merged commit b5aa49c into twisted:master Jun 5, 2015
@IlyaSkriblovsky IlyaSkriblovsky deleted the mongodbcr-testing branch June 5, 2015 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IlyaSkriblovsky @coveralls @psi29a