Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding x509 support #176

Closed
wants to merge 2 commits into from
Closed

Adding x509 support #176

wants to merge 2 commits into from

Conversation

dynamikdev
Copy link
Contributor

adding support for x509
create a specific authenticate_mongo_x509 as other mecanism

adding support for x509 
create a specific authenticate_mongo_x509 as other mecanism
@dynamikdev dynamikdev mentioned this pull request Jul 20, 2016
@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage decreased (-95.6%) to 0.0% when pulling 40e6be6 on dynamikdev:patch-1 into 49cd126 on twisted:master.

@IlyaSkriblovsky
Copy link
Contributor

Wow, that was fast :)

Test failures seem not to be linked with this PR. They probably caused by recent changes in PyMongo.

Is it possible to add some tests for X509? Or it will be too tricky?
Existing tests for MONGODB-CR in tests/test_auth.py start distinct mongod process and create users for testing. May be we can start hardcode test keys in test_auth.py and start mongod with key-based authentication enabled?
But if this cannot be done in a clean way, it is probably to leave it without tests for now.

@dynamikdev
Copy link
Contributor Author

too quickly , i made an error fixed
it quite tricky to test end2end the connection but , i could maybe check the request

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage decreased (-18.06%) to 77.567% when pulling 1bd192a on dynamikdev:patch-1 into 49cd126 on twisted:master.

@IlyaSkriblovsky
Copy link
Contributor

@dynamikdev Could you please rebase your PR onto current master to make sure it passes all the tests? (Currently the PR is marked as failing because master was broken)

@psi29a
Copy link
Contributor

psi29a commented Aug 10, 2016

No need for a rebase, I just kicked travis-ci and it rebuilt the PR against master again. Looks green to me.

@IlyaSkriblovsky
Copy link
Contributor

@psi29a Travis can reapply PR to current master (effectively, do a rebase)? Cool!

@psi29a
Copy link
Contributor

psi29a commented Aug 10, 2016

Not a rebase, but it tries to merge to the latest master at that moment and if there are no merge conflicts, it builds. So I think we got lucky. :)

@IlyaSkriblovsky IlyaSkriblovsky mentioned this pull request Oct 3, 2016
@IlyaSkriblovsky
Copy link
Contributor

transformed into #187 and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants