-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for codec_options #177
Conversation
98a79da
to
62b947e
Compare
@psi29a Bret, it seems that in Twisted-trunk they changed something either in Trial or twisted.python.reflect and not |
That's crap. I'll have a look at it when I can. |
3cf15ab
to
6ee34a7
Compare
6ee34a7
to
4406a29
Compare
Finally tests fixed by #178 and this one |
@psi29a could you please take a look on the code of this patch when you will have a minute |
So this no longer needs a fix for tox? |
Yes, tests issue with latest twisted fixed in another already merged PR. This one fixed regression with PyMongo 3.3. Please take a look on the code and merge it if it's OK. Thanks |
Looks good to me, thank you! That is some high quality documentation as well. :) |
We have used
pymongo.bulk._Bulk
internal class to implement bulk ops. But since PyMongo 3.3.0 that was released a week ago, this class assumes thatCollection
has proper support of codec options.This patch adds
codec_options
toConnectionPool
,Database
andCollection
classes andcodec_options
kwarg toCollection.with_options()
. This fixes our test suite that is failing since PyMongo 3.3 release.I've also added notice in NEWS.rst that
Collection.with_options
should be preferred now instead ofas_class
kwags tofind
. PyMongo had droppedas_class
kwags in 3.0.