Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing and cleaning Travis CI configuration #221

Merged
merged 3 commits into from Jan 1, 2018

Conversation

IlyaSkriblovsky
Copy link
Contributor

I tried to fix Travis CI issue noticed in #219, but went a bit too far :)

(this PR includes changes from #219 in order to pass tests with PyMongo 3.6)

Seems like updated Travis' trusty environment doesn't starts newly-installed mongodb-org-server anymore. So I've added manual mongod run in before_install.

Then build started to fail with tox wasn't able to find Python 3.3... I have no idea of what have changed on the Travis' side, but anyways our previous Travis config seems a bit strange because it ran all py2.7–3.5 tests with python: 2.7 in .travis.yml... So I decided to make it a bit more clear.

• Manually starting mongod since updated Travis' trusty image doesn't starts it after installation anymore
• More clean testing matrix configuration
• Removed testing on Python 3.3 since PyCrypto dropped support for 3.3 and doesn't compiles on it anymore
• Added testing on pypy3
• PyCrypto doesn't compile on PyPy because it tries to build it's fastmath native extension which is incompatible with PyPy. PyCrypto builds this extension only if libgmp-dev is installed, so I added the line that uninstalls it on PyPy builds.
• Added newer Twisted versions for testing against

@coveralls
Copy link

coveralls commented Dec 31, 2017

Coverage Status

Coverage increased (+0.09%) to 95.287% when pulling e30a4fa on IlyaSkriblovsky:travis-fix-2 into c5ee3b4 on twisted:master.

@psi29a
Copy link
Contributor

psi29a commented Jan 1, 2018

LGTM... shouldn't you be enjoying the new year? ;)

@psi29a
Copy link
Contributor

psi29a commented Jan 1, 2018

Thank you for putting the effort into this. I like that we are a bit more explicit here.

@psi29a psi29a merged commit 3de3e6e into twisted:master Jan 1, 2018
@IlyaSkriblovsky
Copy link
Contributor Author

IlyaSkriblovsky commented Jan 1, 2018

LGTM... shouldn't you be enjoying the new year? ;)

What could be better than finally resolving the issue and finally deleting the reminder that was snoozed a dozen of times during the weeks? :)

@IlyaSkriblovsky
Copy link
Contributor Author

I think fixed PyMongo 3.6 compatibility deserves a release because right now txmongo installed by pip install txmongo is broken. I will prepare the version bump PR.

@IlyaSkriblovsky IlyaSkriblovsky deleted the travis-fix-2 branch January 1, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants