Allow collection options to be passed only via kwargs #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
|
I think this is the very good idea to be more in line with pymongo. Thanks! |
|
Agreed! |
|
@stevenkaras can you add an entry here:
Once we have that, we'll merge! :) Thank you very much1 |
This is in line with the pymongo behavior[0], and will make it easier to migrate code from pymongo to txmongo. [0]: https://github.com/mongodb/mongo-python-driver/blob/3.7.2/pymongo/database.py#L304
stevenkaras
force-pushed
the
bugfixes/collection-creation-options
branch
from
e54e5c0
to
f0b257f
Compare
|
@psi29a is there anything else? |
|
Good to go! Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the pymongo behavior, and will make it easier to migrate code from pymongo to txmongo.