Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking if LoopingCall is running before stopping it #260

Merged
merged 1 commit into from Oct 22, 2019
Merged

checking if LoopingCall is running before stopping it #260

merged 1 commit into from Oct 22, 2019

Conversation

IlyaSkriblovsky
Copy link
Contributor

This could raise AssertionError if connection stopped within 10 seconds

Fixes #259

@IlyaSkriblovsky
checking if LoopingCall is running before stopping it
2e8c05f 
This could raise AssertionError if connection stopped within 10 seconds

Fixes #259
@coveralls
Copy link

coveralls commented Oct 22, 2019 •
edited

Coverage Status

Coverage increased (+0.04%) to 93.707% when pulling 2e8c05f on fix-259 into 680f13a on master.

@IlyaSkriblovsky IlyaSkriblovsky mentioned this pull request Oct 22, 2019
Closed
@psi29a
Copy link
Contributor

psi29a commented Oct 22, 2019

Great, lgtm.

@psi29a psi29a merged commit d1df147 into master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertionError: Tried to stop a LoopingCall that was not running.
3 participants
@IlyaSkriblovsky @coveralls @psi29a