Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /1.1/geo/reverse_geocode #584

Closed
myConsciousness opened this issue Dec 3, 2022 · 4 comments · Fixed by #587
Closed

Support /1.1/geo/reverse_geocode #584

myConsciousness opened this issue Dec 3, 2022 · 4 comments · Fixed by #587
Labels
enhancement New feature or request

Comments

@myConsciousness
Copy link
Member

    @myConsciousness 

Thanks for your work.

Can I use /1.1/geo/reverse_geocode here?

I am trying

final res = await api.geo.searchLocations(
            granularity: GeoGranularity.neighborhood,
            latitude:****,
            longitude: ******,
          );

but I got

[埼玉 所沢市, 埼玉 川越市, 埼玉 さいたま市 大宮区,....

It is too broad, I just want to search for the store that is near me.

Originally posted by @normidar in #577 (comment)

@myConsciousness myConsciousness added the enhancement New feature or request label Dec 3, 2022
@myConsciousness
Copy link
Member Author

Hi @normidar , thanks for your feedback :)

Unfortunately, the current implementation does not support the /1.1/geo/reverse_geocode endpoint. This could have been added in the last release, but I could not determine the demand for an endpoint that does reverse geocoding.

However, this endpoint would be very easy to add. I'm looking forward to your pull request! :)

@normidar
Copy link

normidar commented Dec 4, 2022

I created PR!

@bors bors bot closed this as completed in 82ca9d4 Dec 4, 2022
@myConsciousness
Copy link
Member Author

@all-contributors please add @normidar for code, doc, question

@allcontributors
Copy link
Contributor

@myConsciousness

I've put up a pull request to add @normidar! 🎉

bors bot added a commit that referenced this issue Dec 4, 2022
588: docs: add normidar as a contributor for code, doc, and question r=myConsciousness a=allcontributors[bot]

Adds `@normidar` as a contributor for code, doc, question.

This was requested by myConsciousness [in this comment](#584 (comment))

[skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants