Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support /1.1/geo/reverse_geocode #587

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Conversation

normidar
Copy link

@normidar normidar commented Dec 4, 2022

1. Description

fix #584

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #587 (f195955) into main (56821c4) will decrease coverage by 0.46%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   87.54%   87.08%   -0.47%     
==========================================
  Files         154      154              
  Lines        1887     1897      +10     
==========================================
  Hits         1652     1652              
- Misses        235      245      +10     
Impacted Files Coverage Δ
lib/src/service/geo/geo_service.dart 77.77% <0.00%> (-22.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@myConsciousness
Copy link
Member

Hi @normidar , thanks for pull request, it looks great! :)

This pull request will be released as v4.6.0 in a few days along with other commits!

@myConsciousness
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 4, 2022

Build succeeded:

@bors bors bot merged commit 82ca9d4 into twitter-dart:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support /1.1/geo/reverse_geocode
4 participants