Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching a user's profile banner #590

Closed
jordyvandomselaar opened this issue Dec 6, 2022 · 3 comments · Fixed by #631
Closed

Support fetching a user's profile banner #590

jordyvandomselaar opened this issue Dec 6, 2022 · 3 comments · Fixed by #631
Assignees

Comments

@jordyvandomselaar
Copy link

jordyvandomselaar commented Dec 6, 2022

1. Problem to solve

It's currently not possible to fetch a user's profile banner.

2. Proposal

Unfortunately, there is no v2 endpoint to fetch the user's profile banner, but there are multiple v1 endpoints we can use.

I haven't tested those calls, will need some work.

3. More information

  • Yes, I'd be willing to work on a PR for this =)
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Thanks for your contribution! :)

@myConsciousness
Copy link
Member

Hi @jordyvandomselaar , thanks for your feedback :)

I also have been waiting for some time for these v1.1 endpoints to be supported as v2.0, but it seems that official Twitter no longer has the time to devote to the Twitter API.

I'm in favor of implementing these endpoints, but the users/show endpoint seems difficult to map to the v2 User object format. However, the users/profile_banner endpoint could easily be implemented by creating a new object :)

Are you interested in creating a pull request? Let's implement users/profile_banner at first :)

@myConsciousness
Copy link
Member

myConsciousness commented Dec 6, 2022

@jordyvandomselaar ,

If you have any questions about creating a pull request, please do not hesitate to let me know :)

My guess is that this endpoint should be implemented in UsersService.

And please refer to GeoService and TrendsService as a way to implement v1.1 endpoints :)

@myConsciousness myConsciousness linked a pull request Jan 5, 2023 that will close this issue
7 tasks
bors bot added a commit that referenced this issue Jan 5, 2023
631: feat: fixed for the issue (#590) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/twitter-dart/twitter-api-v2/issues
[contributor guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <contact@shinyakato.dev>
bors bot added a commit that referenced this issue Jan 5, 2023
631: feat: fixed for the issue (#590) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/twitter-dart/twitter-api-v2/issues
[contributor guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <contact@shinyakato.dev>
@bors bors bot closed this as completed in #631 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants