Add publish script. #23
Conversation
build.gradle
Outdated
| @@ -21,8 +21,8 @@ buildscript { | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
| // NOTE: Do not place your application dependencies here; they belong | |||
| // in the individual module build.gradle files | |||
| classpath 'com.android.tools.build:gradle:2.3.1' | |||
There was a problem hiding this comment.
Is this still required for a Java only project?
There was a problem hiding this comment.
Good question, file an issue or send a PR for this to discuss separately, I'm not sure.
Edit: Oops, didn't realize I added this. Let me look into it for this PR then.
serialization/publish.gradle
Outdated
| project { | ||
| name "Serial" | ||
| artifactId "serial" | ||
| packaging project.name == 'compiler' ? 'jar' : 'aar' |
There was a problem hiding this comment.
I think we can just use packaging jar.
There was a problem hiding this comment.
Based on our POM file here, https://repo1.maven.org/maven2/com/twitter/serial/serial/0.1.5/serial-0.1.5.pom, I think it's actually "packaging 'aar'" that we want, or maybe that's incorrect? Agree that we don't need this ternary though
There was a problem hiding this comment.
I think JAR is the correct value since the artifact is a jar file.
| } | ||
| } | ||
|
|
||
| publish { |
There was a problem hiding this comment.
All these values can be moved to gradle.properties
There was a problem hiding this comment.
Ah okay, I wasn't sure what should go there, so I just put stuff I expected would change, i.e. just the version name
serialization/publish.gradle
Outdated
| repoName = 'Serial' | ||
| groupId = 'com.twitter.serial' | ||
| artifactId = 'serial' | ||
| publishVersion = project.VERSION_NAME |
There was a problem hiding this comment.
project.VERSION_NAME -> VERSION_NAME
|
LGTM 🚢 |
Using the bintray-release, along with their instructions for publishing to Maven Central