Feature/migrate async summers from sb #296
Conversation
|
This does see like a more reasonable home. I guess the one question is whether we want to have this be in util? I know that @johnynek is on record as hating util packages and I tend to agree. |
|
-util here refers to having a dependency on twitter-util, not that it is util code |
|
Lol, that's embarassing. twitter-util is still poorly named, then :P ok will give it one last lookthrough and then merge |
| def add(t: T) = addAll(Iterator(t)) | ||
| def addAll(vals: TraversableOnce[T]): Future[M] | ||
|
|
||
| def isFlushed: Boolean |
There was a problem hiding this comment.
not a huge sticking point, but imho this is a misleading name as these queues will be flushed many times. hasCachedElements seems more to point but I don't want to spur a bunch of dumb refactoring
There was a problem hiding this comment.
Cache is a bad name here, flush applies to a buffer so kind of covers what this should be closer than that.
Feature/migrate async summers from sb
We had these summers in summingbird for a while, seems like a better home for them is in Algebird however.