Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverageAggregate #414

Closed
wants to merge 8 commits into from
Closed

Add coverageAggregate #414

wants to merge 8 commits into from

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Feb 9, 2015

We need this to get better, but still not accurate, results due to: scoverage/sbt-scoverage#87

@ianoc
Copy link
Collaborator

ianoc commented Feb 9, 2015

lgtm, merge when green

@caniszczyk
Copy link
Contributor

This is good but we fail when we upload results to coveralls:

https://travis-ci.org/twitter/algebird/jobs/50114430#L1321

@ianoc ianoc closed this Aug 4, 2015
@ianoc
Copy link
Collaborator

ianoc commented Aug 4, 2015

Sorry my bad, git foo on cmd line broke stuff and closed all of these

@ianoc ianoc reopened this Aug 4, 2015
@johnynek johnynek mentioned this pull request Nov 18, 2015
@johnynek
Copy link
Collaborator Author

It looks like the tests take too long to run when doing the coverage tracking.

Maybe we can turn down the number of trials in the CMS tests. They seem to be the slow ones in my check:
https://github.com/twitter/algebird/blob/develop/algebird-test/src/test/scala/com/twitter/algebird/CountMinSketchTest.scala#L267

Maybe we can turn down the number of instances on some of these?

@johnynek
Copy link
Collaborator Author

I think it is actually working now: https://coveralls.io/github/twitter/algebird
/cc @sriramkrishnan

@johnynek
Copy link
Collaborator Author

@ianoc I guess this is green now, and we can start showing code coverage. Merge?

@sriramkrishnan
Copy link
Collaborator

Nice. Does it also work if the tests are in a separate package now?

@sriramkrishnan
Copy link
Collaborator

scoverage/sbt-scoverage#87 is still open.

@ianoc
Copy link
Collaborator

ianoc commented Nov 19, 2015

The code coverage values don't look right do they? It also reports on that website that develop was tested/updated last night. But we've made no changes there.

Looking at the results on that coverage page it seems to report only 28 files are covered... none of which are from algebird-core from what i can see.

@johnynek
Copy link
Collaborator Author

about develop: I think that is travis test of the push.

It looks like aggregate testing is indeed broken still. I guess we need a later sbt-coverage plugin, but it appears the coveralls support is lagging, and does not yet support sbt-coverage 1.3.3.

I guess algebird is a uniquely bad case here because all the tests are in another package.

I guess we could try codecov: https://codecov.io/guide

Have to say, this is pretty frustrating shit. We've been trying this for a year or more.

@sritchie
Copy link
Collaborator

sritchie commented Nov 4, 2016

Closing, since we now have codecov.

@sritchie sritchie closed this Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants